Thank you to everyone that has helped me, I have this up and running. Done the following
*ESXI Plug NIC Cable LAN interface port to switch
*ESXI Plug NIC cable WAN interface port to OTA
*ESXI changed VLAN tag in esxi interface port for wan to 4095 (all)
*PFSENSE changed wan IPV4 to PPPoE added user@spark.co.nz and password
*PFSENSE didnt add VLAN10.
everything seems to working fine, but I need to do some more testing.