Incorrect link in subscribed topic email

Forums › Geekzone › Incorrect link in subscribed topic email

nzgeek

574 posts

Ultimate Geek
+1 received by user: 46

Topic # 98539 1-Mar-2012 11:03

I've noticed a problem in the email that tells you there's a new post in a subscribed forum topic. It appears that the page number in the link is out by one.

One email came through today with this URL to the new post: http://www.geekzone.co.nz/forums.asp?forumid=97&topicid=83026&page_no=195#588710. At the time the link came though, the thread was only up to page 194.

If I modify the page number in the URL to be 194 (http://www.geekzone.co.nz/forums.asp?forumid=97&topicid=83026&page_no=194#588710) then the link takes me to the correct post.

When you click on a link with an invalid page number, you get taken to the thread but see no posts. In order to get to the new posts, you need to click on one of the correct page number links.

I don't know if this problem affects all topics, only topics with large numbers of pages, or just this one topic. I'll try subscribing to a few threads and see what URLs come through.

1 | 2

BDFL - Memuneh
58089 posts

Uber Geek
+1 received by user: 9633

Administrator

Trusted

Geekzone

Subscriber

Reply # 588766 1-Mar-2012 11:14

It happens if a reply is removed for example, and the counters are wrong. Things get fixed with time.

Mauricio Freitas (Geekzone Admin, Devil's Advocate, my blog, technology disclosure)

nzgeek

574 posts

Ultimate Geek
+1 received by user: 46

Reply # 588798 1-Mar-2012 12:27

Having deleted posts makes sense. I think the thread in question had a small number deleted at some stage.

This also explains why the first few notifications for new posts on page 195 have a correct URL, but the last few posts on page 194 had an incorrect URL.

Is it possible there's a bug in the code that figures out the page number for the post? I'm thinking something like an incorrect WHERE clause on a SQL statement, where the deleted posts are not getting ignored as they should be.

networkn

13751 posts

Uber Geek
+1 received by user: 3242

Trusted

Subscriber

Reply # 588804 1-Mar-2012 12:37

How can I create a url link to a thread that goes to the last page always?

Foo

498 posts

Ultimate Geek
+1 received by user: 14

Reply # 588851 1-Mar-2012 14:03

The insanely long thread for the SGS Galaxy II is always a bit out, but I guess with 196 pages, that is to be expected?!? :-)

kiwitrc

4123 posts

Uber Geek
+1 received by user: 842
Inactive user

Reply # 588869 1-Mar-2012 14:15

Foo: The insanely long thread for the SGS Galaxy II is always a bit out, but I guess with 196 pages, that is to be expected?!? :-)

You wont be sayin that when they turn that thread into a movie...

freitasm

BDFL - Memuneh
58089 posts

Uber Geek
+1 received by user: 9633

Administrator

Trusted

Geekzone

Subscriber

Reply # 588872 1-Mar-2012 14:16

I wanted to lock the thread so people could create individual discussions for each different problem... They forced me to run away from it...

Mauricio Freitas (Geekzone Admin, Devil's Advocate, my blog, technology disclosure)

Foo

498 posts

Ultimate Geek
+1 received by user: 14

Reply # 588874 1-Mar-2012 14:20

freitasm: I wanted to lock the thread so people could create individual discussions for each different problem... They forced me to run away from it...

It's tough, us Samsung people can be so demanding ;-)

nate

I'm @nate
6271 posts

Uber Geek
+1 received by user: 366

Moderator

Trusted

Subscriber

Reply # 588900 1-Mar-2012 15:08

freitasm: It happens if a reply is removed for example, and the counters are wrong. Things get fixed with time.

Mod question - the Fix link that we can see, I assume this fixes the issue above?

Custom software development | Mt Eden Cafe | Cafe Owner

GeoffisPure

411 posts

Ultimate Geek
+1 received by user: 63

Reply # 588912 1-Mar-2012 15:24

freitasm: I wanted to lock the thread so people could create individual discussions for each different problem... They forced me to run away from it...

I would much prefer this. It feels that the entire thread is about custom ROMs/kernels (something I know nothing about) and basic questions about using the phone are largely ignored.

freitasm

BDFL - Memuneh
58089 posts

Uber Geek
+1 received by user: 9633

Administrator

Trusted

Geekzone

Subscriber

Reply # 588913 1-Mar-2012 15:25

Yes.

Mauricio Freitas (Geekzone Admin, Devil's Advocate, my blog, technology disclosure)

freitasm

BDFL - Memuneh
58089 posts

Uber Geek
+1 received by user: 9633

Administrator

Trusted

Geekzone

Subscriber

Reply # 588914 1-Mar-2012 15:26

Create a new thread for specific questions then.

Mauricio Freitas (Geekzone Admin, Devil's Advocate, my blog, technology disclosure)

freitasm

BDFL - Memuneh
58089 posts

Uber Geek
+1 received by user: 9633

Administrator

Trusted

Geekzone

Subscriber

Reply # 594045 12-Mar-2012 12:20

I have made some changes in the database query we use plus the scripts themselves, and you should see some performance improvement in topic lists (eg. http://www.geekzone.co.nz/forums.asp?forumid=48)

I will be doing some changes to the page numbers soon.

If this change is ok, I will work in the forum thread pages themselves to replicate the database query changes. If it's like the topic lists, we could see an improvement reducing page creation time around 50% in some cases.

Mauricio Freitas (Geekzone Admin, Devil's Advocate, my blog, technology disclosure)

freitasm

BDFL - Memuneh
58089 posts

Uber Geek
+1 received by user: 9633

Administrator

Trusted

Geekzone

Subscriber

Reply # 594067 12-Mar-2012 12:39

Also, the problem with page number in links from other pages should be solved now (unless of course you try to see a reply we've hidden before you got there).

Mauricio Freitas (Geekzone Admin, Devil's Advocate, my blog, technology disclosure)

d3Xt3r

527 posts

Ultimate Geek
+1 received by user: 52

Trusted

Subscriber

Reply # 596087 16-Mar-2012 12:55

freitasm: Also, the problem with page number in links from other pages should be solved now (unless of course you try to see a reply we've hidden before you got there).

Hi freitasm,

I've been getting a LOT of incorrect mails from lately these two threads I'm active in:

"Samsung Galaxy S II Owners Thread"
"Come on Telecom, Samsung Galaxy S2 update"

1. The mails come in quite regularly - like once an hour - even if there have been no replies!
2. The URLs in the mails always point to the same post (the post # changes, but the post I'm taken to is the same one). I keep getting these mails regardless of whether or not there has been a new reply, regardless of whether or not I've already read all the posts in the thread. They can be quite frequent, like just a few minutes apart!

Now I've tried clicking on the unsubscribe link in the mails but it didn't work. I then went to my user preferences and changed it to send me a mail only if there's been a new unread reply per hour. (My previous setting was to always send a new mail).

Would be grateful if you can look into this soon, as the mails are spamming my inbox. Of course, I have created a filter for them for the time being.. but something, somewhere is broken badly.

freitasm

BDFL - Memuneh
58089 posts

Uber Geek
+1 received by user: 9633

Administrator

Trusted

Geekzone

Subscriber

Reply # 596117 16-Mar-2012 14:16

I haven't seen this anywhere... Sure the emails are different?

Could you please give me a list of #[number] you received?

Mauricio Freitas (Geekzone Admin, Devil's Advocate, my blog, technology disclosure)

1 | 2